CP-27343: SR probe: add clustering lock, assert cluster_host enabled #3542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseri
approved these changes
Apr 4, 2018
There was a problem hiding this comment.
Looks reasonable to me but I'd like somebody with more context to have a look. Ping @edwintorok @gaborigloi
|
Why coveralls keeps messing the count? |
|
I don't know how coveralls works, but is it possible that local opens contribute significantly? |
|
I don't think that's the issue. We have seen it happen in multiple PRs lately, even in ones where we ehere deleting lots of code |
edwintorok
requested changes
Apr 4, 2018
minishrink
force-pushed
the
feature/REQ477/check_probe
branch
from
2ae796b to
dc35b09
Compare
edwintorok
force-pushed
the
feature/REQ477/probe
branch
2 times, most recently
from
f304da3 to
e6e7dc2
Compare
|
@minishrink please rebase there are too many commits in the PR, which means you probably have some duplicate commits that are already on the probe branch but with a different hash. |
minishrink
force-pushed
the
feature/REQ477/check_probe
branch
from
dc35b09 to
cd7bd61
Compare
edwintorok
force-pushed
the
feature/REQ477/probe
branch
from
e6e7dc2 to
42f3b9f
Compare
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
minishrink
force-pushed
the
feature/REQ477/check_probe
branch
from
cd7bd61 to
ccfee3c
Compare
edwintorok
approved these changes
Apr 5, 2018
edwintorok
pushed a commit
that referenced
this pull request
Apr 5, 2018
…3542) Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xapi_sr.call_probe(called by bothSR.probeandSR.probe_ext) in a clustering lock in case the SR is in use elsewhere to prevent database inconsistencyStorage_interfaceandStorage_accessSigned-off-by: Akanksha Mathur akanksha.mathur@citrix.com