Skip to content

Conversation

xiewei20082008
Copy link
Contributor

Signed-off-by: Wei Xie wei.xie@citrix.com

@xiewei20082008
Copy link
Contributor Author

Just Having test on this method. Also works.

@robhoes
Copy link
Member

robhoes commented Apr 12, 2018

This may work, but it does a get_phyfn_path twice for every PCI, which is a filesystem operation: once in update_pf_vf_relations and once in update_dependencies.

@coveralls
Copy link

coveralls commented Apr 12, 2018

Coverage Status

Coverage increased (+0.003%) to 20.353% when pulling bcc538b on xiewei20082008:private/weix/CA-286165-update-dependencies into 095a1f8 on xapi-project:master.

Signed-off-by: Wei Xie <wei.xie@citrix.com>
@xiewei20082008 xiewei20082008 force-pushed the private/weix/CA-286165-update-dependencies branch from 19e6e6d to bcc538b Compare April 12, 2018 14:25
@xiewei20082008
Copy link
Contributor Author

xiewei20082008 commented Apr 12, 2018

Hi @robhoes Performance impact solved. Changed a bit of structure of the code. I think it is worth refining it since actually we improved the performance eventually - the update_dependencies is O(n^2) and after the change we just need to do update_dependencies for non-VF only, thinking about in the future we could have a MxVGPU with hundreds of VFs other than current 16 VFs. That is a lot of time. :)

@robhoes robhoes merged commit 7cea812 into xapi-project:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants