Port some Xapi unit tests from OUnit to Alcotest framework #3568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborigloi
reviewed
Apr 18, 2018
ocaml/tests/test_network.ml
Outdated
| ] | ||
| let assert_equal msg p1 p2 = | ||
| let network_purpose = Alcotest_comparators.from_rpc_of_t API.rpc_of_network_purpose in | ||
| Alcotest.(check (list network_purpose)) |
There was a problem hiding this comment.
We need slist here because it's conceptually a set, the order doesn't matter.
gaborigloi
reviewed
Apr 18, 2018
ocaml/tests/test_xapi_db_upgrade.ml
Outdated
| let __context = make_test_database () in | ||
| upgrade_bios_strings.fn ~__context; | ||
| Stdext.Unixext.mkdir_safe "/var/tmp" 0o755; | ||
| Stdext.Unixext.write_string_to_file "/var/tmp/.previousInventory" inventory; |
There was a problem hiding this comment.
It's better to reference the Xapi_stdext_unix module directly, that way we don't have to depend on the whole of stdext.
minishrink
force-pushed
the
alcoblob
branch
3 times, most recently
from
61bb715 to
202576b
Compare
gaborigloi
reviewed
Apr 20, 2018
| let assert_succeed url host port = | ||
| Alcotest.(check (pair string int)) | ||
| "test_split_host_port" | ||
| (split url) (host, port) |
There was a problem hiding this comment.
The expected value should go first here
gaborigloi
approved these changes
Apr 20, 2018
added 7 commits
April 20, 2018 11:17
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
minishrink
changed the title
minishrink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported a few simpler tests while waiting around for a build. We should make a list of which would be the most useful tests to port somewhere.