Remove inactive with_vm quicktests #3577
Conversation
These quicktests are looking for a template that does not exist currently, therefore they are always skipped. Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
gaborigloi
force-pushed
the
remove_unused_quicktests
branch
from
ec3dac3 to
2e50d1f
Compare
|
Why not provide an existing template instead? Or would that not be possible with the current state of the test? |
|
We could try that too, is there is a template that's guaranteed to be there. |
|
Or we could remove them now, and re-add them later when we figure out how to run them? That doesn't hurt, because they are not being run, and they are just in the way because I'm doing a quicktest cleanup. |
|
|
||
| let with_vm s f = | ||
| try | ||
| let (_: API.ref_VM) = find_template s vm_template in |
There was a problem hiding this comment.
If you stick with this, you should probably also remove vm_template from quicktest_common. What if instead we select the first debian or centos template from the list of available templates and keep the tests?
There was a problem hiding this comment.
I'm doing a quicktest rewrite at the moment, and for that it will be more convenient to just remove these temporarily. So I'll remove these in my quicktest rewrite PR, and I'll make a ticket to re-enable them.
4 participants
These quicktests are looking for a template that does not exist
currently, therefore they are always skipped.
Signed-off-by: Gabor Igloi gabor.igloi@citrix.com