Skip to content

CA-176973: lvrename - retry when devmapper throws an exception #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2015
Merged

CA-176973: lvrename - retry when devmapper throws an exception #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion xenvm/lvrename.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,21 @@
open Cmdliner
open Lwt

let retry fn =
let rec inner n =
match n with
| 0 -> return (fn ())
| n ->
try
return (fn ())
with e ->
Printf.fprintf stderr "Caught exception: %s. Retrying.\n%!" (Printexc.to_string e);
Lwt_unix.sleep 1.0 >>=
fun () ->
inner (n-1)
in
inner 5

let lvrename copts (vg_name,lv_opt) newname physical_device =
let module Devmapper = (val !Xenvm_common.dm : Devmapper.S.DEVMAPPER) in
let lv_name = match lv_opt with | Some l -> l | None -> failwith "Need an LV name" in
Expand All @@ -28,7 +43,8 @@ let lvrename copts (vg_name,lv_opt) newname physical_device =
let all = Devmapper.ls () in
let old_name = Mapper.name_of vg lv in
if List.mem old_name all then begin
Devmapper.remove old_name;
retry (fun () -> Devmapper.remove old_name)
>>= fun () ->
Mapper.read [ local_device ]
>>= fun devices ->
let targets = Mapper.to_targets devices vg lv in
Expand Down