Skip to content

Conversation

jonludlam
Copy link
Collaborator

CP-13495

Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
@djs55
Copy link
Collaborator

djs55 commented Jul 31, 2015

Do you need to update opam to add stringext too?

On Fri, 31 Jul 2015 15:08 Jon Ludlam notifications@github.com wrote:


You can view, comment on, or merge this pull request online at:

#133
Commit Summary

  • Add stringext
  • Persist which hosts have connected via LVM tags
  • Reconnect to hosts after a restart

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#133.

@jonludlam
Copy link
Collaborator Author

Aha yes, good spot thanks. I think we're already implicitly getting it via another library (cohttp perhaps?), but it's better to be explicit about these things.

Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
Also, diff -u to make reading the output easier.

Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
jonludlam pushed a commit that referenced this pull request Jul 31, 2015
@jonludlam jonludlam merged commit adfb912 into xapi-project:master Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants