Erase metadata volumes which we create #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because the volumes may already have the correct
signature (e.g. from a previous run) but now contain stale data
which must be discarded.
- When host.create creates {to,from}LVM volumes, it explicitly
erases them.
- Vgcreate erases the xenvmd journal volume
This relies on [djs55/mirage-block-volume#64]
Signed-off-by: David Scott <dave.scott@citrix.com>
Signed-off-by: David Scott <dave.scott@citrix.com>
djs55
force-pushed
the
avoid-infinite-loops
branch
from
ec219b0 to
c135579
Compare
djs55
added a commit
that referenced
this pull request
Apr 30, 2015
Erase metadata volumes which we create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because the volumes may already have the correct
signature (e.g. from a previous run) but now contain stale data
which must be discarded.
erases them.
This relies on [djs55/mirage-block-volume#64]
Signed-off-by: David Scott dave.scott@citrix.com