Fix bugs and make more robust #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 7, 2015 13:33
If we ask for 1 bytes we should use (1 + extent_size - 1) / extent_size i.e. we should allocate a whole extent even though it is more than what we asked for. Fixes #65 Signed-off-by: David Scott <dave.scott@citrix.com>
…locator We can shrink deactivated volumes as normal through the API. The local allocator can only allocate, so fail if shrinking is requested. Also avoid calling the local allocator to allocate 0 bytes. Signed-off-by: David Scott <dave.scott@citrix.com>
It will exit with 0 only if the resize has been successful. Otherwise it will print a diagnostic message to stderr and exit with non-zero. Fixes #66 Signed-off-by: David Scott <dave.scott@citrix.com>
Signed-off-by: David Scott <dave.scott@citrix.com>
We create a lock file based on the Unix domain socket path to prevent a second instance starting up. Signed-off-by: David Scott <dave.scott@citrix.com>
If we are listening on a path, we create a lock file based on the path name. If we are listening on a TCP port, we rely on the bind being exclusive (although the TCP code is deprecated) Signed-off-by: David Scott <dave.scott@citrix.com>
I suspect the daemonize code was closing the fd and releasing the lock. Fixes #67 Signed-off-by: David Scott <dave.scott@citrix.com>
Signed-off-by: David Scott <dave.scott@citrix.com>
…ee blocks We missed one case where this could happen: when initially registering a host where the local allocator has been spawned previously. Signed-off-by: David Scott <dave.scott@citrix.com>
added 2 commits
May 7, 2015 20:45
Previously we would try to allocate everything we needed in one chunk. If the free space isn't available we would block. However xenvmd does not know we need more space and won't give us more, so we deadlock. Instead we allocate as much as we can (up to the amount we really need), expand the volume, thus draining the free pool, which triggers xenvmd to refill it. Fix #69 Signed-off-by: David Scott <dave.scott@citrix.com>
…ng order In particular device mapper likes its targets to be posted in order of virtual address. Signed-off-by: David Scott <dave.scott@citrix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugs:
robustness: