Skip to content

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Sep 3, 2025

@larsbuntemeyer can you take a look please

@dcherian dcherian force-pushed the complex-grid-mapping branch from 309e18d to c5dfc7a Compare September 3, 2025 16:06
@dcherian dcherian force-pushed the complex-grid-mapping branch 2 times, most recently from d27d633 to abee56f Compare September 3, 2025 17:17
@dcherian dcherian force-pushed the complex-grid-mapping branch from abee56f to 5410abf Compare September 3, 2025 17:18
@dcherian dcherian requested a review from aulemahal September 3, 2025 17:18
@dcherian dcherian changed the title Support multiple grid mappings on a DataArray Support multiple grid mappings; Add new GridMapping dataclass Sep 3, 2025
name: str
crs: Any # really pyproj.CRS
array: xr.DataArray
coordinates: tuple[str, ...]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aulemahal the cartopy_crs property could be added here with any workarounds.

Copy link
Contributor

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, looks good!

I think the "coordinate" fallback might be a bit too broad.

@dcherian dcherian force-pushed the complex-grid-mapping branch from ecbe054 to 87ccd42 Compare September 3, 2025 23:04
dcherian and others added 4 commits September 4, 2025 09:11
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
@dcherian dcherian enabled auto-merge (squash) September 4, 2025 15:31
@dcherian dcherian disabled auto-merge September 4, 2025 15:31
@dcherian dcherian force-pushed the complex-grid-mapping branch from ca823e5 to da3a557 Compare September 4, 2025 15:41
@dcherian dcherian merged commit 5609564 into main Sep 4, 2025
11 checks passed
@dcherian dcherian deleted the complex-grid-mapping branch September 4, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants