-
Notifications
You must be signed in to change notification settings - Fork 1
Update xarray dependency, switch to pixi #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR migrates the project from Poetry to a PEP 621-based setup using hatch/hatchling and Pixi for environment and build management, updating metadata, dependencies, CI workflows, and developer docs to reflect the change. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @melonora - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `pyproject.toml:30` </location>
<code_context>
+
+requires-python = ">=3.8, <3.14"
+dependencies = [
+ "numpy >=2.0.0,<3",
+ "xarray >=2025.7.1,<2026",
+ "typing-extensions>=4.10.0,<5"]
</code_context>
<issue_to_address>
The numpy dependency is set to ">=2.0.0,<3", which may be too restrictive.
Since most users are still on numpy 1.x, this version constraint may block installations. Please consider allowing the latest 1.x versions unless 2.x is specifically required.
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
||
requires-python = ">=3.8, <3.14" | ||
dependencies = [ | ||
"numpy >=2.0.0,<3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: The numpy dependency is set to ">=2.0.0,<3", which may be too restrictive.
Since most users are still on numpy 1.x, this version constraint may block installations. Please consider allowing the latest 1.x versions unless 2.x is specifically required.
As the original repo does not seem to be active at the moment and there is a request to change the xarray dependency, a fork was created and changes have been made to fullfill the request here.
Originally, the repository was also using poetry as packager / dependency manager, but I find it usually gives problems for developers also dealing with projects with conda. Therefore, I changed it to make use of pixi.
Summary by Sourcery
Migrate from Poetry to PEP-621 packaging with hatchling and Pixi, update xarray dependency, and adjust CI and contribution docs accordingly
Enhancements:
Build:
CI:
Documentation:
Chores: