Custom dependencies #178
Custom dependencies #178
Conversation
|
I think full documentation should be another PR when all changes are made #177 |
xsimlab/tests/test_model.py
Outdated
| model = xs.Model( | ||
| {"a": A, "b": B, "c": C, "d": D}, | ||
| custom_dependencies={"d": "c", "c": "b", "b": "a"}, | ||
| ) | ||
| model = model.drop_processes(["b", "c"]) | ||
| assert model.dependent_processes["d"] == ["a"] | ||
|
|
There was a problem hiding this comment.
I improved this test in #183, apologies for the confusion. It does not test a branch.
|
Just to say that I'm sorry for the long wait and for my absence of reaction so far @joeperdefloep! I've been struggling these last months to get to review your PRs, to test it and to ensure that we're using the right approach, as the changes here touch one of the core design concepts in xarray-simlab. I hope to be able to do this properly during the next couple of months. |
|
Yes, that would be super nice! I'd LOVE not having to work off my own dev branch anymore :) especially if I am going to integrate LandLab in some way (would be exciting!) Also the biggest part is in strict-check, in terms of reviewing complexity. Most of everything I implemented is a Depth-First Search (DFS) in different places.. The docs explain strict checking, which is the most important piece on how everything is implemented. Let me know if you run into anything! Edit: the tests are a bit ugly atm in the sense that I make a lot of classes in each test, but having these globally would also be weird, insights on that would be appreciated! |
|
Hey @benbovy just another message that this review would be very nice! Now my university is looking into reworking some of their erosion models, and this package is of interest! Also, I could maybe split the DFS and tests from removing processes... |
|
Hi @joeperdefloep, yes sorry (again), this is still on my radar. I've been busy with other projects, notably a big refactor in Xarray to allow custom and explicit indexes, but I should have more time once the Xarray related PR is merged. Thank you for your patience! |
|
No need to be sorry, it sounds like you are doing great work! I now found out how to point to my branch in |
|
Just popped to my mind that using a BFS would probably make the logic easier. Also now I use git-branchless which makes splitting work into branches a lot easier. I could even split out the DFS's from the remove functions if wanted :) |
black . && flake8whats-new.rstfor all changes andapi.rstfor new APIadded custom dependencies #177, #164
I also added logic for drop_processes, because otherwise that would break. (A bit stubborn of me, apologies 😋 )