Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor (Webhook)Provider hierarchy #221

Closed
gdaniel opened this issue May 6, 2019 · 0 comments
Closed

Refactor (Webhook)Provider hierarchy #221

gdaniel opened this issue May 6, 2019 · 0 comments
Assignees
@gdaniel
Labels
Enhancement New feature or request Server

Comments

@gdaniel
Copy link
Member

gdaniel commented May 6, 2019

There are some inconsistencies with the provider hierarchy: the ChatIntentProvider extends RuntimeIntentProvider, meaning that platforms extending chat cannot use a webhook to receive user inputs.
The quick fix used for now is to define an empty RuntimeIntentProvider subclass (see React platform) that dynamically create a WebhookProvider and registers it to the server.
This should be properly solved by setting ChatIntentProvider as an interface, allowing to consider both RuntimeIntentProviders and WebhookProviders as chat providers.

This issue is related to #220
@gdaniel gdaniel added this to the Awaiting Integration milestone May 6, 2019
@gdaniel gdaniel self-assigned this May 6, 2019
@gdaniel gdaniel changed the title Refactory (Webhook)Provider hierarchy Refactor (Webhook)Provider hierarchy May 15, 2019
@gdaniel gdaniel added Enhancement New feature or request and removed Core labels Aug 18, 2019
@gdaniel gdaniel closed this as completed in f58f201 Sep 3, 2019
gdaniel added a commit to xatkit-bot-platform/xatkit-chat-platform that referenced this issue Sep 3, 2019
@gdaniel
refactor provider hierarchy (refs xatkit-bot-platform/xatkit-runtime#221
cee7fad 
)

ChatPlatform now contains 2 providers that extend the ones from the runtime component:
- ChatIntentProvider that can be extended by providers based on third-party libraries (e.g. Slack)
- JsonWebhookChatIntentProvider that can be extended by providers receiving messages as JSON payloads
gdaniel added a commit to xatkit-bot-platform/xatkit-slack-platform that referenced this issue Sep 3, 2019
@gdaniel
fix provider imports (refs xatkit-bot-platform/xatkit-runtime#221)
858bfb3
gdaniel added a commit to xatkit-bot-platform/xatkit-discord-platform that referenced this issue Sep 3, 2019
@gdaniel
fix provider imports (refs xatkit-bot-platform/xatkit-runtime#221)
408c063
gdaniel added a commit to xatkit-bot-platform/xatkit-react-platform that referenced this issue Sep 3, 2019
@gdaniel
fix provider imports (refs xatkit-bot-platform/xatkit-runtime#221)
597ac70
gdaniel added a commit to xatkit-bot-platform/xatkit-zapier-platform that referenced this issue Sep 4, 2019
@gdaniel
fix provider imports (refs xatkit-bot-platform/xatkit-runtime#221)
2f6f4e8
@gdaniel gdaniel removed this from the Next Release milestone Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdaniel gdaniel

Labels
Enhancement New feature or request Server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdaniel