-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: Remove MAC address reading code for iOS #1011
Conversation
cb02e92
to
38a4e7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we support iOS >= 12, iirc it stopped working in 14 or 15. Not sure why you want to remove this ability from older devices.
Main reason is that I would like to avoid anyway non-supported (and potentially harmful) message processing on top of the straight functionality. The used headers are submitted to the repo and not coming from the SDK. I am not even sure, if these headers redefine any values. |
ok, let's remove. And I also see a better way how to resolve MAC address: add new method to Kodi RPC to return it, as Kodi does have access to MAC address (except when running on iOS/tvOS).
that's not good for sure |
those headers are from Apple OpenSource project (Darwin basically), you could also simply try updating them |
Updated the network headers from Darwin project and made another change to remove the complete server-ping in case the MAC address resolving is not supported. How to move on from here? |
daf4eb5
to
8208d59
Compare
I hoped that updated headers have changes that would make it work on the modern iOS, but seems that there're only whitespace changes and new symbols. Let's simply delete them from the repo then. Btw do I understand correctly that WoL sending doesn't rely on the private headers? |
|
This is anyway blocked by iOS since version 14.
#head on April 2nd, 2024.
8208d59
to
639a794
Compare
|
Description
This PR removes code which reads the MAC address for iOS device builds (simulator still allows this). This functionality is anyway blocked by iOS since several versions. The motivation is to avoid any undesired side effect by calling anyway non-supported code.
Summary for release notes
Maintenance: Remove MAC address reading code for iOS