Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Remove MAC address reading code for iOS #1011

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

wutschel
Copy link
Collaborator

Description

This PR removes code which reads the MAC address for iOS device builds (simulator still allows this). This functionality is anyway blocked by iOS since several versions. The motivation is to avoid any undesired side effect by calling anyway non-supported code.

Summary for release notes

Maintenance: Remove MAC address reading code for iOS

@wutschel wutschel force-pushed the no_macaddress_ios branch 2 times, most recently from cb02e92 to 38a4e7c Compare March 30, 2024 20:45
Copy link
Collaborator

@kambala-decapitator kambala-decapitator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we support iOS >= 12, iirc it stopped working in 14 or 15. Not sure why you want to remove this ability from older devices.

XBMC Remote/HostViewController.m Outdated Show resolved Hide resolved
@wutschel
Copy link
Collaborator Author

wutschel commented Apr 2, 2024

Main reason is that I would like to avoid anyway non-supported (and potentially harmful) message processing on top of the straight functionality. The used headers are submitted to the repo and not coming from the SDK. I am not even sure, if these headers redefine any values.

@kambala-decapitator
Copy link
Collaborator

ok, let's remove. And I also see a better way how to resolve MAC address: add new method to Kodi RPC to return it, as Kodi does have access to MAC address (except when running on iOS/tvOS).

The used headers are submitted to the repo and not coming from the SDK

that's not good for sure

@kambala-decapitator
Copy link
Collaborator

those headers are from Apple OpenSource project (Darwin basically), you could also simply try updating them

@wutschel
Copy link
Collaborator Author

wutschel commented Apr 2, 2024

Updated the network headers from Darwin project and made another change to remove the complete server-ping in case the MAC address resolving is not supported.

How to move on from here?

@kambala-decapitator
Copy link
Collaborator

Updated the network headers from Darwin project and made another change to remove the complete server-ping in case the MAC address resolving is not supported.

How to move on from here?

I hoped that updated headers have changes that would make it work on the modern iOS, but seems that there're only whitespace changes and new symbols. Let's simply delete them from the repo then.

Btw do I understand correctly that WoL sending doesn't rely on the private headers?

@wutschel
Copy link
Collaborator Author

wutschel commented Apr 2, 2024

  1. On WOL I have no idea and I cannot test this. Can you give it a try?
  2. As this feature is still nice when working with simulator, I would not remove all of it, but just limit the functionality to non-iOS.

This is anyway blocked by iOS since version 14.
@kambala-decapitator
Copy link
Collaborator

  1. On WOL I have no idea and I cannot test this. Can you give it a try?
  2. As this feature is still nice when working with simulator, I would not remove all of it, but just limit the functionality to non-iOS.
  1. I see that WoL uses only standard socket communication, so it's fine.
  2. ok fine

@kambala-decapitator kambala-decapitator merged commit a350ba7 into xbmc:master Apr 3, 2024
@wutschel wutschel deleted the no_macaddress_ios branch April 3, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants