Bugfix: Do not end up in debug messages when searching in add ons #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
force-pushed
the
rework_keyboard
branch
from
b819688
to
b0e046c
Compare
kambala-decapitator
approved these changes
Feb 19, 2024
kambala-decapitator
approved these changes
Feb 20, 2024
- Remove magic number - Introduce variable to allow calling GUIAction only once
To avoid a debug message when sending "" from virtual keyboard to addon search a dedicated check is added to DetailViewController to only show "no results".
The keyboard must be canceled if the view is left (viewWillDisappear). For this, the new notification Input.OnInputCanceled is introduced which is used to send Input.Back to Kodi in case the keyboard is in editing mode (active).
This prevents a potential race condition where the Kodi keyboard is already gone, but the App's keyboard is still up. Sending "Back" in this case will let Kodi leave the current context.
Simplify the layout calculation in textFieldDidBeginEditing, scale the layout for iPad. reduce magic numbers and improve variable naming, This change now also maintains the same bottom padding under the text field, with or without a keyboard title.
wutschel
force-pushed
the
rework_keyboard
branch
from
d55a86c
to
57b1ffe
Compare
|
Squashed and rebased to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #986.
Virtual keyboard might have been closed on App, but not on Kodi, which resulted in unexpected debug errors on the App. This is now resolved by canceling the Kodi keyboard by sending "Input.Back" in case of an active keyboard being canceled in the App. In addition, the App does now not show a debug message, when
""was sent to the Addon search. Instead, only the "no items found" message is seen.On top, this PR does some refactoring and hygiene changes like indentation and white spaces corrections, removes unneeded parameters and refactors the code which send the text.
Summary for release notes
Bugfix: Do not end up in debug message when searching in add ons