Skip to content

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Sep 7, 2016

This PR implements some caching mechanisms for team logos and league data as requested by @zag2me in http://forum.kodi.tv/showthread.php?tid=258252&pid=2408318#pid2408318 in order to reduce the database server load.

Many thanks

@zag2me
Copy link

zag2me commented Sep 8, 2016

Thanks, Is the default 7 days? Does it need to be so short?

I can't imagine the team logos and details changing too much over the season.

@enen92
Copy link
Member Author

enen92 commented Sep 8, 2016

I can increase it. What is your suggestion for the list of values?

@zag2me
Copy link

zag2me commented Sep 8, 2016

I'd say 2 weeks as a start, lets see how that goes

return addon.getLocalizedString(text).encode('utf-8')

def filewrite(_file,contents):
f = open(_file, "w")

This comment was marked as spam.

Set default timedelta for cache operations as 2w

Use with statement for file IO

Changelog wrong version
@enen92
Copy link
Member Author

enen92 commented Sep 8, 2016

Updated PR with @zag2me and @phil65 suggestions

@phil65
Copy link
Contributor

phil65 commented Sep 8, 2016

Thx!

@phil65 phil65 merged commit bd00f3d into xbmc:isengard Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants