Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtitle addons restructuring #1444

Closed
wants to merge 1 commit into from
Closed

subtitle addons restructuring #1444

wants to merge 1 commit into from

Conversation

amet
Copy link
Contributor

@amet amet commented Sep 19, 2012

  • xbmc.python.subtitles hidden in addons manager
  • create xbmc.subtitle.module so that subtitle addon services can be installed as modules

as discussed with @cptspiff on IRC here is a PR that will allow subtitle service authors to submit the service as module to a main XBMC Subtitle script(or any other one that might come up in future).

only services will be visible from now on and main script settings can be accessed from skin settings and/or addon itself.

this change will not break any skin settings and it should just transition seamlessly once frodo repo is available.

Cheers,
amet

- xbmc.python.subtitles hidden in addons manager
- create xbmc.subtitle.module so that subtitle addon services can be installed as modules
@amet
Copy link
Contributor Author

amet commented Sep 21, 2012

as per @pieh code earlier, amended and force pushed

@amet amet closed this Oct 1, 2012
@amet amet reopened this Oct 2, 2012
@jmarshallnz
Copy link
Contributor

I think this is good to go, as long as the subtitle script prompts the user on run if they don't have any modules installed.

It's a little bit icky for the user as they'd be first prompted to select a subtitle script (on press of the subtitles button in Confluence) and then, once they run this, will be again redirected to install a module. All while trying to play a video.

There's 2 steps involved:

  1. Confluence prompts user for which subtitle script they want, so it knows which one to run.
  2. The script needs to prompt for missing modules.

We could take care of 1 by bundling the script - the user could still potentially replace it if there's a skin setting for it (it just defaults to the bundled one).

The second can just be done via the appropriate ActivateWindow call.

@amet
Copy link
Contributor Author

amet commented Oct 3, 2012

  1. would be fine on upgraded eden->frodo versions, and as it always was on new systems. you have to set the script either in skin settings or you get prompted when hitting the subtitle button on OSD if the script was not set. no skin changes would be needed for any of it.
  2. I have taken care of it in here, that way the script will close and user can download and enable the service(one time only), but unfortunately user will have to go back to full screen and run the script again.
    service_id_list = xbmcvfs.listdir("addons://enabled/xbmc.subtitle.module/")[1]
    if not service_id_list:
      xbmc.executebuiltin('XBMC.ActivateWindow(addonbrowser, addons://all/xbmc.subtitle.module)')

EDIT: I personally wouldn't want it bundled in the XBMC, people don't always need subtitles and find it unnecessary to have installed. one thing we could look into would be to not offer the user a script selection if only one is installed, but that might involve some skin and/or more xbmc changes

@amet
Copy link
Contributor Author

amet commented Oct 8, 2012

change of heart here... after all its better if this doesn't go in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature non-breaking change which adds functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants