[pvr] Added Icon, thumbnail and fanart support for recordings #1455

Merged
merged 3 commits into from Oct 3, 2012

Conversation

Projects
None yet
2 participants
Member

fetzerch commented Sep 21, 2012

This PR adds support for showing icon, thumbnail and fanart images for recordings.
The paths to those images have to be provided by the addon.

Cheers,
Christian

Member

opdenkamp commented Sep 26, 2012

could you stick the cosmetics in a separate commit please, so i can review it properly. thanks

@ghost ghost assigned opdenkamp Sep 26, 2012

Member

fetzerch commented Sep 26, 2012

Sure, done. Due to the change in PVR_RECORDING, addons need to be recompiled. I guess that means we need to bump the version?

Member

opdenkamp commented Sep 26, 2012

correct, both numbers need to be updated for this

Member

opdenkamp commented Sep 27, 2012

rest is fine, if you could stick the skin fix in a seperate PR, then it'll be merged in next round

Member

fetzerch commented Sep 28, 2012

Moved the skin change to a separate PR. However it's somewhat related. Without that the fanarts aren't shown.

Member

opdenkamp commented Oct 1, 2012

no idea why github is still showing a green button, but the version number should be bumped to 1.4.0 for this now. could you update it please.

Member

fetzerch commented Oct 1, 2012

done

opdenkamp pushed a commit that referenced this pull request Oct 3, 2012

Merge pull request #1455 from fetzerch/feature-pvr-recordingimages
[pvr] Added Icon, thumbnail and fanart support for recordings

@opdenkamp opdenkamp merged commit d875510 into xbmc:master Oct 3, 2012

@ghost ghost referenced this pull request in pipelka/xbmc-addon-xvdr Oct 12, 2012

Closed

thumbnail and timeshift support #70

tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Dec 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment