[pvr] Added Icon, thumbnail and fanart support for recordings #1455

Merged
merged 3 commits into from Oct 3, 2012

Projects

None yet

2 participants

@fetzerch
Member

This PR adds support for showing icon, thumbnail and fanart images for recordings.
The paths to those images have to be provided by the addon.

Cheers,
Christian

@opdenkamp
Member

could you stick the cosmetics in a separate commit please, so i can review it properly. thanks

@opdenkamp opdenkamp was assigned Sep 26, 2012
@fetzerch
Member

Sure, done. Due to the change in PVR_RECORDING, addons need to be recompiled. I guess that means we need to bump the version?

@opdenkamp
Member

correct, both numbers need to be updated for this

@opdenkamp
Member

rest is fine, if you could stick the skin fix in a seperate PR, then it'll be merged in next round

@fetzerch
Member

Moved the skin change to a separate PR. However it's somewhat related. Without that the fanarts aren't shown.

@opdenkamp
Member

no idea why github is still showing a green button, but the version number should be bumped to 1.4.0 for this now. could you update it please.

@fetzerch
Member
fetzerch commented Oct 1, 2012

done

@opdenkamp opdenkamp merged commit d875510 into xbmc:master Oct 3, 2012
@ghost Unknown referenced this pull request in pipelka/xbmc-addon-xvdr Oct 12, 2012
Closed

thumbnail and timeshift support #70

@tru tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Dec 15, 2014
@tru tru Fix cloud sync for photos.
Fixes #1455
d33a844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment