[pvr] Added Icon, thumbnail and fanart support for recordings #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you stick the cosmetics in a separate commit please, so i can review it properly. thanks |
|
Sure, done. Due to the change in PVR_RECORDING, addons need to be recompiled. I guess that means we need to bump the version? |
|
correct, both numbers need to be updated for this |
|
rest is fine, if you could stick the skin fix in a seperate PR, then it'll be merged in next round |
|
Moved the skin change to a separate PR. However it's somewhat related. Without that the fanarts aren't shown. |
|
no idea why github is still showing a green button, but the version number should be bumped to 1.4.0 for this now. could you update it please. |
|
done |
opdenkamp
pushed a commit
that referenced
this pull request
Oct 3, 2012
[pvr] Added Icon, thumbnail and fanart support for recordings
ghost
mentioned this pull request
tru
pushed a commit
to plexinc/plex-home-theater-public
that referenced
this pull request
Dec 15, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for showing icon, thumbnail and fanart images for recordings.
The paths to those images have to be provided by the addon.
Cheers,
Christian