Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macos] change Toggle Fullscreen shortcut to system default Cmd+Ctrl+F #17161

Merged

Conversation

kambala-decapitator
Copy link
Contributor

Description

Changes Toggle Fullscreen shortcut to system default Cmd+Ctrl+F.

Motivation and Context

Common macOS shortcut to enter fullscreen mode is Cmd+Ctrl+F, but Kodi uses Cmd+F. Also requested in https://forum.kodi.tv/showthread.php?tid=349123.

How Has This Been Tested?

Tested new shortcut by pressing respective keys.

Screenshots (if appropriate):

Screenshot 2020-01-09 at 18 43 00

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@kambala-decapitator kambala-decapitator added Platform: macOS v19 Matrix Type: Breaking change fix or feature that will cause existing functionality to change labels Jan 9, 2020
@kambala-decapitator kambala-decapitator merged commit 3717b80 into xbmc:master Feb 22, 2020
@kambala-decapitator kambala-decapitator deleted the macos-fullscreen-shortcut branch February 22, 2020 08:45
kambala-decapitator added a commit that referenced this pull request Feb 22, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Feb 24, 2020
…en-shortcut

[macos] change Toggle Fullscreen shortcut to system default Cmd+Ctrl+F
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Feb 24, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Feb 26, 2020
…en-shortcut

[macos] change Toggle Fullscreen shortcut to system default Cmd+Ctrl+F
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Feb 26, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
…en-shortcut

[macos] change Toggle Fullscreen shortcut to system default Cmd+Ctrl+F
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
…en-shortcut

[macos] change Toggle Fullscreen shortcut to system default Cmd+Ctrl+F
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
…en-shortcut

[macos] change Toggle Fullscreen shortcut to system default Cmd+Ctrl+F
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
…en-shortcut

[macos] change Toggle Fullscreen shortcut to system default Cmd+Ctrl+F
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
…en-shortcut

[macos] change Toggle Fullscreen shortcut to system default Cmd+Ctrl+F
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
…en-shortcut

[macos] change Toggle Fullscreen shortcut to system default Cmd+Ctrl+F
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
…en-shortcut

[macos] change Toggle Fullscreen shortcut to system default Cmd+Ctrl+F
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: macOS Type: Breaking change fix or feature that will cause existing functionality to change v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant