Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unattended Install has garbled EULA screen on first boot #493

Closed
ed-at-protectli opened this issue Apr 29, 2021 · 5 comments
Closed

Unattended Install has garbled EULA screen on first boot #493

ed-at-protectli opened this issue Apr 29, 2021 · 5 comments

Comments

@ed-at-protectli
Copy link

When using an unattended installation with 8.2.0, the first (or subsequent) boot shows the EULA acceptance screen, but the text appears to be broken.

image

greppable text:

/usr/share/doc/* folders.grams, please read each COPYING file in thenow more

XCP-ng comes with no warranty, to the extent permitted by applicable law.

For more info on XCP-ng, please check https://xcp-ng.org
https://xcpng.comrt for production environment is available on

Our answerfile is as follows:

<?xml version="1.0"?>
    <installation mode="fresh">
        <primary-disk>sda</primary-disk>
        <keymap>us</keymap>
        <root-password type="hash">!!</root-password>
        <source type="url">http://[redacted]/xcp-ng/8.2.0/</source>
        <admin-interface name="eth0" proto="dhcp" />
        <timezone>Europe/Paris</timezone>
    </installation>

This only appears on some hardware, as the appropriate screen will show on other hardware using the same installation method. I wish there was some way to reliably reproduce it, but it seems specific to the host hardware. Any additional information you'd like about the hardware can be supplied, but it's difficult to just provide something succinct as this is on development OEM hardware (e.g. I can't just link to some document with all hardware specs).

@olivierlambert
Copy link
Member

Hi!

We are aware of this, and IIRC it's fixed in our master branch. However, it requires to build a new ISO. If you like, we can do it for you but we won't replace the already existing publicly available one before a bit.

Pinging @stormi

@stormi
Copy link
Member

stormi commented Apr 29, 2021

It is also possible to fix it with a script called by the answerfile, during the installation process, without waiting for new ISOs.

@ed-at-protectli
Copy link
Author

A script returned by the answerfile seems like the path of least resistance for us. We haven't set up a build environment for xcp-ng and just rely on the released ISOs.

If there is a specific commit/pr/etc that I can refer to that has the fix, I'd appreciate being pointed in the right direction.

@stormi
Copy link
Member

stormi commented Apr 29, 2021

The fixed EULA can be found at https://github.com/xcp-ng/branding-xcp-ng/blob/master/branding/EULA and must be copied the one in /EULA on the installed system IIRC.

You can define a script to be run in the context of the installed system with <script stage="filesystem-populated" type="nfs|url">url</script>. See https://github.com/xcp-ng/host-installer/blob/master/doc/answerfile.txt#L104.

The first argument passed to the script is the path to the directory where the filesystem is mounted.

@ed-at-protectli
Copy link
Author

Oh, the fix is literally just replacing a single text file. I was thinking this was a much more convoluted issue with ncurses/xsconsole. I'll just repackage our image with the new file. I misunderstood the earlier comments, assuming that a true "build from source" was needed, instead of just replacing a single file in the finished image. Thanks, guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants