-
Notifications
You must be signed in to change notification settings - Fork 6
Added missing options #141, #143, #144 #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
#143 Added the missing https://www.chartjs.org/docs/latest/configuration/elements.html#point-styles |
/** | ||
* The subtitle configuration is passed into the options.subtitle namespace. The global options for the chart subtitle is | ||
* defined in Chart.defaults.global.subtitle. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like your Javadoc formatting is off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use Ctrl+Shift+F to format the code and javadoc, but it changes the format completely. So, I made it manually :) Is there a better way to do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you did the right thing not reformatting the whole file i think fixing it by hand is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use Ctrl+Shift+F to format the code and javadoc, but it changes the format completely. So, I made it manually :) Is there a better way to do it?
Have a look at our CONTRIBUTING.md. Once setup correctly your IntelliJ does everything for you.
Thank you for the PR and the issues :) LGTM, however codestyle is broken. I will do a quick reformat. |
Fixes #141
Fixes #143
Fixes #144