Skip to content

Added missing options #141, #143, #144 #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 13, 2024

Conversation

aripddev
Copy link
Contributor

@aripddev aripddev commented May 10, 2024

Fixes #141
Fixes #143
Fixes #144

@aripddev
Copy link
Contributor Author

#143 Added the missing rectRounded in PointStyle.

https://www.chartjs.org/docs/latest/configuration/elements.html#point-styles

@aripddev aripddev changed the title Added Subtitle option Added missing options #141, #143 May 10, 2024
@aripddev aripddev changed the title Added missing options #141, #143 Added missing options #141, #143, #144 May 10, 2024
/**
* The subtitle configuration is passed into the options.subtitle namespace. The global options for the chart subtitle is
* defined in Chart.defaults.global.subtitle.
*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your Javadoc formatting is off?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use Ctrl+Shift+F to format the code and javadoc, but it changes the format completely. So, I made it manually :) Is there a better way to do it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you did the right thing not reformatting the whole file i think fixing it by hand is fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use Ctrl+Shift+F to format the code and javadoc, but it changes the format completely. So, I made it manually :) Is there a better way to do it?

Have a look at our CONTRIBUTING.md. Once setup correctly your IntelliJ does everything for you.

@AB-xdev AB-xdev self-assigned this May 13, 2024
@AB-xdev AB-xdev self-requested a review May 13, 2024 06:23
@AB-xdev
Copy link
Member

AB-xdev commented May 13, 2024

Thank you for the PR and the issues :)

LGTM, however codestyle is broken.

I will do a quick reformat.

AB-xdev added 2 commits May 13, 2024 08:35
Save actions didn't trigger as this line was not changed...
@AB-xdev AB-xdev merged commit 3984ad4 into xdev-software:develop May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing pointStyle option in BubbleDataset Missing PointStyle Missing "Subtitle" option
3 participants