Add entity_status to Campaign, fix pep8 issues. #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephtyler
force-pushed
the
feature/add_entity_status
branch
from
3a15aeb to
02cbf6c
Compare
juanshishido
approved these changes
Nov 23, 2017
There was a problem hiding this comment.
Thanks for contributing, @josephtyler!
I've made two, small suggestions. Please fix it, then ship it.
Note: entity_status is now writable on both campaigns and line items. See this announcement for details on this change.
Thanks again!
tests/fixtures/campaigns_all.json
Outdated
| "standard_delivery": true, | ||
| "total_budget_amount_local_micro": null, | ||
| "id": "2wap7", | ||
| "paused": false, |
There was a problem hiding this comment.
Let's remove all instances of paused
twitter_ads/campaign.py
Outdated
| resource_property(Campaign, 'created_at', readonly=True, transform=TRANSFORM.TIME) | ||
| resource_property(Campaign, 'updated_at', readonly=True, transform=TRANSFORM.TIME) | ||
| resource_property(Campaign, 'deleted', readonly=True, transform=TRANSFORM.BOOL) | ||
| resource_property(Campaign, 'entity_status', readonly=True) |
There was a problem hiding this comment.
entity_status is writable on both campaigns and line items.
|
Ok, I've added Looks like someone with write access needs to merge. Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entity_statusto Campaign objectFixes #132 and #134.