Skip to content

Conversation

smaeda-ks
Copy link
Contributor

@smaeda-ks smaeda-ks commented Sep 16, 2019

Change

  • Move Analytics class from the resource.py to the new analytics.py since it's just doesn't make sense at all to keep it in there.
    User Impact: For those who historically imported Analytics class from resource.py need to change import path:
- from twitter_ads.resouce import Analytics
+ from twitter_ads.analytics import Analytics

Add

  • LineItemApps - doc
  • LineItemPlacements - doc
  • ContentCategories - doc
  • IabCategories - doc

Documentation

  • Add more general usage code comments as much as possible... (aligning with Sphinx style)

@smaeda-ks smaeda-ks changed the title [WIP] General updates [WIP] Minor updates Sep 16, 2019
@smaeda-ks smaeda-ks self-assigned this Sep 16, 2019
Copy link
Contributor

@tushdante tushdante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smaeda-ks smaeda-ks changed the title [WIP] Minor updates Minor updates Oct 7, 2019
@smaeda-ks smaeda-ks merged commit 598e86c into xdevplatform:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants