Skip to content

Conversation

ariarijp
Copy link
Contributor

@ariarijp ariarijp commented Nov 7, 2019

Hi team,

Sometimes I got an error caused by network connection from the API.
e.g. urllib3.exceptions.ConnectTimeoutError

I think we can add timeout option to Request class for better error handling.

Thanks,

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2019

CLA assistant check
All committers have signed the CLA.

@smaeda-ks smaeda-ks self-requested a review November 7, 2019 07:23
@smaeda-ks smaeda-ks self-assigned this Nov 7, 2019
@smaeda-ks
Copy link
Contributor

Hey @ariarijp, Thanks for submitting this PR. This looks a good addition for sure.
Though I've submitted a PR to your fork repo here: ariarijp#1 Can you merge it?

My PR is basically adding this new option retry_on_timeouts so users can retry on the timeouts error as well.

@ariarijp
Copy link
Contributor Author

Hi @smaeda-ks,

I also think that it's a good idea. I did merge your PR into mine.

@smaeda-ks
Copy link
Contributor

@ariarijp Thanks mate! Merging this PR

@smaeda-ks smaeda-ks merged commit c0ecae5 into xdevplatform:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants