This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
Add openvslam_ros #276
Closed
Add openvslam_ros #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesurp
reviewed
Apr 6, 2020
| std::shared_ptr<openvslam::config> cfg_; | ||
| ros::NodeHandle nh_; | ||
| image_transport::ImageTransport it_; | ||
| decltype(std::chrono::steady_clock::now()) tp_0_; |
There was a problem hiding this comment.
std::chrono::steady_clock::time_point might be cleaner here I think?
There was a problem hiding this comment.
Thanks for reviewing it.
I've fixed it in 9f25af0 .
|
Sorry for the very late reply and thank you so much for providing the nice PR. Before I review this PR, could you tell me features you intend to add? |
|
This PR contains the following:
|
|
Thank you for providing us the information. |
This was referenced Jan 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to improve maintainability of the ROS wrapper.
It includes
#274changes.