-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linter non-style issues, add modules #42
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly okay, couple of changes or clarifications I'd like.
What linter is this? golint
isn't giving these unused result warnings for me. Nothing I've used ever suggested the change similar to that made in types/util.go
's rescue
function either.
I stand corrected - these warnings were produced by Most of the changes are fixes for the warning of the |
There are still some warnings left, but they are mostly non-essential. |
Ready to be reviewed again. |
Thanks for adding the modules @nezorflame! You might want to split the module patch and the style changes into two separate PRs for easier review. While I have no opinion about the style changes, I think the added modules are a great improvement. |
This reverts commit b1b65e9.
This PR fixes few issues reported by
golangci-lint
lintersgolint
,govet
,gosec
,unused
anderrcheck
.Also adds preliminary support for Go modules.