Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go modules support #61

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

nezorflame
Copy link
Contributor

@nezorflame nezorflame commented Jul 23, 2019

As asked in #42 I separated module-related changes from the linter fixes.

Now people will be able to just do go get github.com/xeals/signal-back (or add @latest, @v0.2.0) like the old times (starting with Go 1.12) and get the required binary release with proper dependencies.

By design repo should now also tag the signal/vX.Y.Z releases of the signal autogenerated submodule, so that other people could use it without dragging the whole binary with it.
This will in turn allow doing go get github.com/xeals/signal-back/signal (or with version suffix like with the binary).

If this gets merged, I suggest tagging the merge commit with 2 tags:

  • v0.2.0 for the repo itself
  • signal/v0.1.0 for the submodule

it's a good practice to separate those from the main package for the other people to use them on their own
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant