Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended Distinction between IBM JRE and Others #168

Merged
merged 1 commit into from
Feb 3, 2016
Merged

Extended Distinction between IBM JRE and Others #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/main/java/com/xebialabs/overthere/cifs/winrm/KerberosJaasConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,20 +49,26 @@ public AppConfigurationEntry[] getAppConfigurationEntry(String s) {
options.put("debug", "true");
}

if (ticketCache) {
options.put("useTicketCache", "true");
} else {
options.put("useTicketCache", "false");
}

options.put("refreshKrb5Config", "true");

if (JavaVendor.isIBM()) {
options.put("credsType", "initiator");

if (ticketCache) {
options.put("useDefaultCcache", "true");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to write two c's there? According to this document the property is called useDefaultCache, with a single c instead of Cc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did mean useDefaultCcache. We found the distinction in this IBM document.

} else {
options.put("useDefaultCcache", "false");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to write two c's there? According to this document the property is called useDefaultCache, with a single c instead of Cc.

}
} else {
options.put("client", "true");
options.put("useKeyTab", "false");
options.put("doNotPrompt", "false");

if (ticketCache) {
options.put("useTicketCache", "true");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code can be simplified as follows:

options.put("useTicketCache", ticketCache.toString())

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, that's a good idea.

} else {
options.put("useTicketCache", "false");
}
}

return new AppConfigurationEntry[]{new AppConfigurationEntry(JavaVendor.getKrb5LoginModuleName(),
Expand Down