Skip to content

Conversation

bernhardkaindl
Copy link
Contributor

docs: Cleanup the not used variants for the UTF-8 migration

Base commit to pass CI:

  • Remove the temporary exclusion of xcp/dmv.py from the diff/patch-coverage analysis
  • Update CI to pass again, fails currently due to a 0.1% calculation change.

A simple PR without product code changes:

  • Fix CI
  • Cleanup obsolete docs on possibilities to handle UTF-8 that we didn't use.

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up documentation and CI configuration following UTF-8 migration work. The changes focus on removing obsolete documentation about unused UTF-8 handling variants and adjusting CI thresholds to fix failing tests.

  • Remove temporary exclusion of xcp/dmv.py from diff coverage analysis
  • Lower test coverage threshold from 96% to 95% to accommodate calculation changes
  • Cleanup obsolete documentation sections about unused UTF-8 handling approaches

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tox.ini Removes temporary exclusion from diff coverage and adjusts test coverage threshold
README-Unicode.md Removes documentation for unused UTF-8 handling variants, keeping only the implemented approach

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

This comment was marked as off-topic.

@bernhardkaindl bernhardkaindl merged commit d2929b2 into xenserver:master Sep 26, 2025
8 checks passed
@bernhardkaindl bernhardkaindl deleted the docs-cleanup-not-used-variants-for-utf8-migration branch September 26, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants