Skip to content

Conversation

bernhardkaindl
Copy link
Contributor

Fix Markdownlint:

  • Fix Long lines
  • Fix text blocks
  • Exclude Sphinx-internal files that only include the README files from checking.

Base commit to pass CI:

  • Remove the temporary exclusion of xcp/dmv.py from the diff/patch-coverage analysis
  • Update CI to pass again, fails currently due to a 0.1% calculation change.

A simple PR without product code changes

  • Fix CI,
  • Fix Errors from Markdown linting,
  • Fix Syntax errors while highlighting code and text blocks.

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes various CI and Markdown linting issues without changing product code functionality.

  • Adjusts test coverage threshold from 96% to 95% to fix CI failures
  • Fixes Markdown linting issues by properly formatting code blocks and excluding Sphinx files
  • Removes temporary exclusion of xcp/dmv.py from diff coverage analysis

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tox.ini Reduces test coverage threshold and removes xcp/dmv.py exclusion
README-Unicode.md Fixes code block formatting and improves text clarity
.pre-commit-config.yaml Excludes Sphinx-internal files from Markdown linting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot

This comment was marked as resolved.

This comment was marked as off-topic.

@bernhardkaindl bernhardkaindl changed the title Fix Markdownlint: Long lines, text blocks, includes Fix Markdownlint: Fix long lines, text blocks and exclude Sphinx-internal files. Sep 23, 2025
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl bernhardkaindl force-pushed the Fix-CI-and-markdownlint-errors branch from a453fe7 to 8c7c3a4 Compare September 23, 2025 11:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bernhardkaindl bernhardkaindl merged commit 13faf33 into xenserver:master Sep 26, 2025
8 checks passed
@bernhardkaindl bernhardkaindl deleted the Fix-CI-and-markdownlint-errors branch September 26, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants