CA-375900: Prepend \\?\ to file paths when creating streams for archive generation
#3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hive generation The string works to enable creation of files with paths larger than 260 characters. Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
kc284
requested changes
Aug 1, 2023
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
`Directory.GetFiles` and `Directory.GetDirectories` do not enumerate if paths are longer than 260, even when prepended with `//?/`. Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
danilo-delbusso
added
updated
danilo-delbusso
changed the title
//?/ to file paths when creating streams for archive generation\\?\ to file paths when creating streams for archive generation
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
danilo-delbusso
added
ITE
CitrixChris
added
ITE
kc284
reviewed
Sep 5, 2023
kc284
added
needs updating
…chiveIterator` Also improves progress reporting by basing it on directory count Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
…d path lengths Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
…e using long path format If files in the directory exceed the 260 character limit, the calls will fail Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
…and path lengths Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
danilo-delbusso
added
updated
CitrixChris
added
ASAP
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
The import uses `DiscUtils` which cannot handle paths prepended with `//?/` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
CitrixChris
approved these changes
Sep 18, 2023
This partially reverts commit 819425855c56c14b937849714b359003465bd2f4. Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
CitrixChris
previously approved these changes
Sep 20, 2023
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
CitrixChris
approved these changes
Sep 22, 2023
kc284
approved these changes
Sep 22, 2023
kc284
added
2 approvals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You'll need a host/pool with GFS2 storage to replicate this, as it creates large paths in
%temp%when generating the Server Status Report.The string works to enable creation of files with paths larger than 260 characters. This solution avoids us having to update registry keys which is an unwanted side effect.
7zip does this already so bypassing Windows restrictions has precedents. Plus this restriction isn't even relevant for our uses. We only really use it to build the archive.
Resources: