Horss migration #35
Merged
Horss migration #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maximelucas
commented
Dec 23, 2021
maximelucas
commented
- Added small functions to the HyperGraph class
- Added generator of random hypergraph
- Added functions related to Add function to remove singleton from edges #29
nwlandry
reviewed
Dec 27, 2021
nwlandry
reviewed
Dec 27, 2021
nwlandry
reviewed
Dec 27, 2021
nwlandry
requested changes
Dec 27, 2021
There was a problem hiding this comment.
There are a few imports broken in your Erdos-Renyi function - I might add a few tests. Overall everything looks good - very nice! Some of the imports will be fixed when the merge conflicts are fixed (The main branch has been updated since you created the horss branch) but good to fix these prior to merging nonetheless
leotrs
reviewed
Jan 5, 2022
leotrs
requested changes
Jan 5, 2022
…/xgi into horss_migration
lordgrilo
requested changes
Jan 7, 2022
There was a problem hiding this comment.
No particular comments to the latest commit by Max. The only problem I found was a merge conflict with main due to test functions being present there for non uniform HG and not on horss-migration. I believed I resolved them. This is ok for me. I'm flagging this as request changes so that Nick/leo can check the other changes they requested.
The main branch does not use pandas in the generators module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.