Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tutorials to top level #550

Merged
merged 13 commits into from
Jun 8, 2024
Merged

Move tutorials to top level #550

merged 13 commits into from
Jun 8, 2024

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Jun 7, 2024

This PR uses nbsphinx-link to move the tutorials back to the top level so that not only can nbsphinx render the notebooks for the website, but users can easily access the notebooks as well. This PR also fixes a few small extraneous things, namely:

  • Now the encapsulation_dag page has the correct name
  • We no longer use pkg_resources to determine the version and the contributing guide now reflects that.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (8ab20d8) to head (6dc809e).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   92.35%   92.35%   -0.01%     
==========================================
  Files          60       60              
  Lines        4500     4499       -1     
==========================================
- Hits         4156     4155       -1     
  Misses        344      344              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@thomasrobiglio thomasrobiglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you @nwlandry

@nwlandry
Copy link
Collaborator Author

nwlandry commented Jun 8, 2024

Thanks for the review, @thomasrobiglio! :D

@nwlandry nwlandry merged commit c0f7593 into main Jun 8, 2024
24 checks passed
@nwlandry nwlandry deleted the move-tutorials branch June 10, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants