Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #564

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Fix broken links #564

merged 3 commits into from
Jul 19, 2024

Conversation

nwlandry
Copy link
Collaborator

Fix the broken links since the tutorials were moved.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (40b2d9f) to head (d3250e6).
Report is 44 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   92.51%   92.51%           
=======================================
  Files          59       59           
  Lines        4393     4393           
=======================================
  Hits         4064     4064           
  Misses        329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasrobiglio
Copy link
Collaborator

Nice @nwlandry thank you! I have noticed that there are also links in the tutorials that were broken with the moving (I think all of them are in the Getting started tutorials. Lmk know if you want to do the changes yourself or I can also do it.

@nwlandry
Copy link
Collaborator Author

@thomasrobiglio I won't have a chance to do this today or tomorrow, so feel free to make the changes, approve, and merge! If not, I'll get to it at some point.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nwlandry
Copy link
Collaborator Author

Actually, I had a bit of time open up, so working on this now!

@nwlandry
Copy link
Collaborator Author

All fixed, @thomasrobiglio!

Copy link
Collaborator

@thomasrobiglio thomasrobiglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! All good, thank you also for adding the .ipynb files to the urls-checking routing.

@nwlandry
Copy link
Collaborator Author

Thanks for the review!

@nwlandry nwlandry merged commit 1b575b6 into main Jul 19, 2024
24 checks passed
@nwlandry nwlandry deleted the fix-broken-links branch July 19, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants