-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Egonet a.k.a. per-edge neighbors #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean to me! :)
Looks good. Do we want |
I think a set is more meaningful because it makes it more readily apparent that each neighbor appears only once. |
Alright since you both think it's good - this is ready for review. Any thoughts on the name of the method? |
I think it's good. Regarding the name, I would not intuitively go looking for Do we want to add the |
Oh good call - that makes me think we might want to leave this for later so we may have a systematic way of filtering edges by order across the entire codebase... |
I'm moving the conversation from #32 to here.
The current is a proof of concept. We just have to agree on the name and whether we want an analogous method for edges. Once we agree on that, I'll implement those and add tests.
Demo:
Closes #32.