frame: plane: Fix Downsampling of odd sized frames #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did AWCY and noticed there is a very small encoding time improving by less than a second or second which is neglible, Good news is nothing is broken. |
|
Could you make a downsampling test that shows this? See the existing downsample test - make an odd sized ones. |
takehirokj
reviewed
Feb 5, 2020
Currently, the hres and qres are talking half(1/2) and one-fourth(1/4) of the width and height which is rounded down, when we have an odd sized frame this becomes a problem so to solve that we are rounding one up for both width and height. Earlier: src.cfg.width / 2 Now : (src.cfg.width + 1) / 2, Fixes xiph#2055
vibhoothi
force-pushed
the
downsample_odd
branch
from
06cf778
to
3fb58a5
Compare
takehirokj
reviewed
Feb 5, 2020
barrbrain
reviewed
Feb 6, 2020
There was a problem hiding this comment.
The test case describes the expectation that padding pixels be used when down-sampling planes of odd dimensions. This requires that padding pixels are available, which is true of width if both stride and alignment are even. Odd heights are less constrained, so some care may be required. In practice, we substantially pad the frames to simplify motion estimation.
vibhoothi
force-pushed
the
downsample_odd
branch
from
3fb58a5
to
6c572ac
Compare
Here we have modified the test case since we are considering odd heights, the exceptional case is where the right or bottom padding are zero causing additional pixels to be read from the next row or past the end of the data Co-authored-by: David Michael Barr <b@rr-dav.id.au>
vibhoothi
force-pushed
the
downsample_odd
branch
from
6c572ac
to
a18627f
Compare
barrbrain
approved these changes
Feb 6, 2020
takehirokj
approved these changes
Feb 6, 2020
barrbrain
added a commit
to barrbrain/rav1e
that referenced
this pull request
Oct 5, 2022
* frame: plane: Fix Downsampling of odd sized frames Currently, the hres and qres are talking half(1/2) and one-fourth(1/4) of the width and height which is rounded down, when we have an odd sized frame this becomes a problem so to solve that we are rounding one up for both width and height. Earlier: src.cfg.width / 2 Now : (src.cfg.width + 1) / 2, Fixes xiph#2055 * frame: plane: Introduce new test case for down_sampling Here we have modified the test case since we are considering odd heights, the exceptional case is where the right or bottom padding are zero causing additional pixels to be read from the next row or past the end of the data Co-authored-by: David Michael Barr <b@rr-dav.id.au> * benches: plane: Introduce new bench with odd frames Co-authored-by: David Michael Barr <b@rr-dav.id.au>
barrbrain
added a commit
to barrbrain/rav1e
that referenced
this pull request
Oct 5, 2022
* frame: plane: Fix Downsampling of odd sized frames Currently, the hres and qres are talking half(1/2) and one-fourth(1/4) of the width and height which is rounded down, when we have an odd sized frame this becomes a problem so to solve that we are rounding one up for both width and height. Earlier: src.cfg.width / 2 Now : (src.cfg.width + 1) / 2, Fixes xiph#2055 * frame: plane: Introduce new test case for down_sampling Here we have modified the test case since we are considering odd heights, the exceptional case is where the right or bottom padding are zero causing additional pixels to be read from the next row or past the end of the data Co-authored-by: David Michael Barr <b@rr-dav.id.au> * benches: plane: Introduce new bench with odd frames Co-authored-by: David Michael Barr <b@rr-dav.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently, the hres and qres are talking half(1/2) and one-fourth(1/4) of the
width and height which is rounded down, when we have an odd-sized frame this becomes
a problem so to solve that we are rounding one up for both width and height.
Earlier: src.cfg.width / 2
Now : (src.cfg.width + 1) / 2,
Fixes #2055
I am not 100% if doing this causes any other harm, but it would be great, to hear the comments with this