Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace binary log in segmentation_optimize with a polynomial approximation in Q11 #3004

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

barrbrain
Copy link
Collaborator

Adapted from oc_blog32_q10() in libtheora with blessing from @tterribe.

AWCY results on ojective-1-fast at default speed:

PSNR Y PSNR Cb PSNR Cr CIEDE2000 SSIM MS-SSIM PSNR-HVS Y PSNR-HVS Cb PSNR-HVS Cr PSNR-HVS VMAF VMAF-NEG
0.4305 0.3834 -0.2535 0.1353 -0.2666 -0.2792 0.3404 0.4239 -0.1232 0.4060 0.1488 0.1788

Timothy B. Terriberry and others added 2 commits August 30, 2022 01:15
Translated-By: David Michael Barr <b@rr-dav.id.au>
AWCY results for objective-1-fast at default speed:

PSNR Y | PSNR Cb | PSNR Cr | CIEDE2000 |    SSIM | MS-SSIM
0.4305 |  0.3834 | -0.2535 |    0.1353 | -0.2666 | -0.2792

PSNR-HVS Y | PSNR-HVS Cb | PSNR-HVS Cr | PSNR-HVS |   VMAF | VMAF-NEG
    0.3404 |      0.4239 |     -0.1232 |   0.4060 | 0.1488 |   0.1788
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I'd enjoy having some constants used instead of magic numbers ^^

@barrbrain
Copy link
Collaborator Author

Sure, I tried to translate as faithfully to the original code as possible while meeting language, formatting and linting constraints.

@barrbrain barrbrain merged commit 75fcd60 into xiph:master Aug 29, 2022
@barrbrain barrbrain deleted the segment-opt branch August 29, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants