Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UB in pred_max test #3030

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Fix UB in pred_max test #3030

merged 1 commit into from
Sep 29, 2022

Conversation

redzic
Copy link
Collaborator

@redzic redzic commented Sep 29, 2022

Fixes #3029

@codecov-commenter
Copy link

Codecov Report

Base: 86.44% // Head: 86.45% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (14451f7) compared to base (bc8da6f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3030   +/-   ##
=======================================
  Coverage   86.44%   86.45%           
=======================================
  Files          89       89           
  Lines       34094    34094           
=======================================
+ Hits        29474    29475    +1     
+ Misses       4620     4619    -1     
Impacted Files Coverage Δ
src/predict.rs 81.56% <100.00%> (ø)
src/rdo.rs 85.24% <0.00%> (-0.37%) ⬇️
v_frame/src/plane.rs 88.78% <0.00%> (-0.23%) ⬇️
src/deblock.rs 94.90% <0.00%> (-0.08%) ⬇️
src/cpu_features/x86.rs 39.58% <0.00%> (ø)
src/encoder.rs 87.13% <0.00%> (+0.06%) ⬆️
src/header.rs 69.06% <0.00%> (+0.12%) ⬆️
src/api/internal.rs 97.69% <0.00%> (+0.23%) ⬆️
src/context/partition_unit.rs 89.72% <0.00%> (+0.55%) ⬆️
src/context/transform_unit.rs 90.49% <0.00%> (+0.71%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@redzic redzic merged commit d56fe64 into xiph:master Sep 29, 2022
@redzic redzic deleted the fix-tests branch September 29, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined behavior in predict::test::pred_max
3 participants