Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for platforms without rusage support #3246

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

englishm
Copy link
Contributor

More accurately report that resource usage reporting is not supported on these platforms since the lack of support is not necessarily a Windows-only issue.

Addresses #2517

More accurately report that resource usage reporting is not supported on
these platforms since the lack of support is not necessarily a
Windows-only issue.

Addresses xiph#2517
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 72.72% and no project coverage change.

Comparison is base (2447fcc) 88.10% compared to head (62f8a62) 88.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3246   +/-   ##
=======================================
  Coverage   88.10%   88.10%           
=======================================
  Files          85       85           
  Lines       33596    33596           
=======================================
  Hits        29599    29599           
  Misses       3997     3997           
Impacted Files Coverage Δ
src/bin/rav1e.rs 76.83% <ø> (ø)
src/scenechange/fast.rs 45.36% <0.00%> (+0.46%) ⬆️
src/scenechange/mod.rs 82.12% <88.88%> (-0.36%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lu-zero lu-zero merged commit df521ce into xiph:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants