Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add typescript support #16

Merged
merged 4 commits into from
Aug 5, 2023
Merged

feat: add typescript support #16

merged 4 commits into from
Aug 5, 2023

Conversation

c0reme
Copy link
Contributor

@c0reme c0reme commented Aug 1, 2023 •
edited
Loading

This was requested within #15

  • Fix response data bugs be685cc
  • Seperate typings for typescript users to import 9ae32b4
  • Final external project checks 856ccd9

@c0reme
Copy link
Contributor Author

c0reme commented Aug 1, 2023

If there was something I missed or added please let me know, I was following both what was included under the JSDocs and xivapi.com/docs 👍

@c0reme c0reme marked this pull request as draft August 1, 2023 21:13
@kaimoe
Copy link
Member

kaimoe commented Aug 5, 2023

Thanks for all the effort! Is this still a draft or good to go?

@c0reme
Copy link
Contributor Author

c0reme commented Aug 5, 2023 via email •
edited
Loading

@c0reme c0reme marked this pull request as ready for review August 5, 2023 15:13
@c0reme
Copy link
Contributor Author

c0reme commented Aug 5, 2023

Thanks for all the effort! Is this still a draft or good to go?

It is good to go now!

@kaimoe kaimoe merged commit 005de52 into xivapi:master Aug 5, 2023
@kaimoe kaimoe mentioned this pull request Aug 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c0reme @kaimoe