TACO-20 adding rx in tests for easy async #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdex
approved these changes
May 4, 2018
| } catch (Exception e) { | ||
| timeout = e; | ||
| } | ||
| private void verify(Iterable<Pair> responses) { |
There was a problem hiding this comment.
can you put a blurb in here explaining how you're using javarx to produce/consume Pairs?
| } | ||
| Response response = client.newCall(request.build()).execute(); | ||
| log.debug("response {}", response); | ||
| emitter.onSuccess(new Pair(index, response)); |
There was a problem hiding this comment.
I'm assuming that javarx is going to catch exceptions and emit them as failures
There was a problem hiding this comment.
right - SingleObserver has an onError method... for tests we're just using blockingIterable which will throw when onError is observed
manimaul
commented
May 4, 2018
| log.debug("response {}", response); | ||
| emitter.onSuccess(new Pair(index, response)); | ||
| }) | ||
| .subscribeOn(Schedulers.io())); |
There was a problem hiding this comment.
sultle nuance to rxjava: subscribeOn can only be applied once to the upstream source ... this schedules work on the rx "io" thread pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.