Skip to content

Conversation

edclement
Copy link
Contributor

@edclement edclement commented Feb 25, 2022

Changes

  • Update XLTS for AngularJS to 1.5.15
  • Update XLTS for AngularJS Material to 1.1.29
  • Update tools/populate-lib.sh to work on both Linux and macOS.

When the tools/populate-lib.sh file was invoked on Linux the directory structure would duplicate the last part of the path. For example:

cp -R node_modules/angular/ www/lib/angular/

...would end up copying files from the source path into www/lib/angular/angular/ instead of www/lib/angular/. This article explains the difference in how cp -R implementation varies between Linux and macOS. The updated script has been tested to work on both Linux and macOS.

Other Notes

I did some quick testing to ensure everything was working and noticed that running any of the following npm scripts seemed to not do anything:

npm run start:android
npm run start:ios
npm run build:android
npm run build:ios
npm run prepare:android
npm run prepare:ios

Running any of the above scripts would give the following output:

  ionic-v1

  Usage:

    $ ionic-v1 <command> [<args>] [--help] [options]

  Commands:

    build
    serve

...which basically indicated that the ionic-v1 cli did understand the arguments. The same output could be produced by running the ionic-v1 cli without any arguments (./node_modules/.bin/ionic-v1). I'm not very familiar with Ionic or Cordova so I didn't want to spend too much time investigating but thought it would be worthwhile bringing this up in this PR. @Splaktar is there something obvious I'm missing?

@edclement edclement requested a review from Splaktar February 25, 2022 16:55
@edclement edclement self-assigned this Feb 25, 2022
- use `ionic-v1` only for running the web version
- add `@ionic/cli` use it for all Cordova-related commands
- update `native-run`
- move `cordova` packages to `devDependencies`
@Splaktar
Copy link
Contributor

Good catch. That was not easy to resolve. I think that it's all working properly now.

@Splaktar Splaktar merged commit 8cb364d into master Feb 25, 2022
@Splaktar Splaktar deleted the 116_update_xlts_angularjs branch February 25, 2022 19:30
@edclement
Copy link
Contributor Author

Good catch. That was not easy to resolve. I think that it's all working properly now.

👍🏼 Seems to be resolved (I pulled down the commit you made). I thought about digging into it further but didn't want to waste time if it was just me missing something obvious due to lack of knowledge regarding Ionic/Cordova.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants