Update XLTS for AngularJS #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
tools/populate-lib.sh
to work on both Linux and macOS.When the
tools/populate-lib.sh
file was invoked on Linux the directory structure would duplicate the last part of the path. For example:...would end up copying files from the source path into
www/lib/angular/angular/
instead ofwww/lib/angular/
. This article explains the difference in howcp -R
implementation varies between Linux and macOS. The updated script has been tested to work on both Linux and macOS.Other Notes
I did some quick testing to ensure everything was working and noticed that running any of the following npm scripts seemed to not do anything:
Running any of the above scripts would give the following output:
...which basically indicated that the
ionic-v1
cli did understand the arguments. The same output could be produced by running theionic-v1
cli without any arguments (./node_modules/.bin/ionic-v1
). I'm not very familiar with Ionic or Cordova so I didn't want to spend too much time investigating but thought it would be worthwhile bringing this up in this PR. @Splaktar is there something obvious I'm missing?