Skip to content

feat: Update package.json dependencies to the latest versions, migrat… #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 20, 2023
Merged

feat: Update package.json dependencies to the latest versions, migrat… #8

merged 6 commits into from
Apr 20, 2023

Conversation

jzolnowski
Copy link

  • Update package,json dependencies to the latest version
  • Migrate Gulp to v4
  • Update README

@jzolnowski jzolnowski requested a review from gkalpak February 22, 2023 13:43
gkalpak
gkalpak requested changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions.
Otherwise lgtm 👍

@jzolnowski
Copy link
Author

@gkalpak PR ready for final review

gkalpak
gkalpak requested changes Mar 8, 2023
View reviewed changes
gkalpak
gkalpak approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Splaktar
Splaktar suggested changes Mar 9, 2023
View reviewed changes
@jzolnowski
Copy link
Author

jzolnowski commented Mar 10, 2023 •
edited
Loading

@Splaktar PR ready for final review

Splaktar
Splaktar suggested changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the package-lock.json file in GitHub but please make sure that is was generated with npm v6.

@jzolnowski
Copy link
Author

generate package-lock.json with npm v6

package-lock.json generated with npm v6

@Splaktar
Copy link
Contributor

@jzolnowski please rebase and resolve conflicts.

@jzolnowski
Copy link
Author

Branch is up-to-date with master

@Splaktar
Copy link
Contributor

@jzolnowski please rebase and resolve conflicts.

@jzolnowski jzolnowski force-pushed the feature/update-package-json-deps branch from ab09fd2 to b9dc89e Compare April 17, 2023 17:59
@jzolnowski
Copy link
Author

@jzolnowski please rebase and resolve conflicts.

Branch rebased with master

gkalpak
gkalpak previously requested changes Apr 19, 2023
View reviewed changes
@Splaktar Splaktar merged commit c06bc8d into master Apr 20, 2023
@Splaktar Splaktar deleted the feature/update-package-json-deps branch April 20, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkalpak gkalpak gkalpak left review comments

+1 more reviewer

@Splaktar Splaktar Splaktar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzolnowski @Splaktar @gkalpak