Skip to content

refactor: improve repo workflow and configuration #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 3, 2023
Merged

refactor: improve repo workflow and configuration #9

merged 5 commits into from
May 3, 2023

Conversation

jzolnowski
Copy link

@jzolnowski jzolnowski commented Feb 17, 2023 •
edited
Loading

Improve workflow to not worry about the www/lib/ directory

gkalpak
gkalpak requested changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments/questions, but overall lgtm 🎉

@gkalpak gkalpak mentioned this pull request Mar 6, 2023
Merged
@jzolnowski
Copy link
Author

@gkalpak PR ready for final review

gkalpak
gkalpak approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Splaktar
Splaktar suggested changes Mar 10, 2023
View reviewed changes
Splaktar
Splaktar reviewed Mar 10, 2023
View reviewed changes
@Splaktar Splaktar changed the title Feature/improve workflow refactor: improve repo workflow and configuration Mar 10, 2023
@jzolnowski
Copy link
Author

Both @Splaktar comments applied. Ready for final review

Splaktar
Splaktar suggested changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json's engines field requires npm v6, but this PR updates the package-lock.json version to v2. I think that we should ensure that we only use npm v6 with this repo and rollback the changes to the package-lock.json file from npm v7 or v8.

@jzolnowski
Copy link
Author

jzolnowski commented Mar 16, 2023 •
edited
Loading

The package.json's engines field requires npm v6, but this PR updates the package-lock.json version to v2. I think that we should ensure that we only use npm v6 with this repo and rollback the changes to the package-lock.json file from npm v7 or v8.

I set the engine-strict flag in .npmrc. I updated the npm and node versions in the package.json engines: npm v9, node>=18. I tested if the package installation and start of the application works correctly. Everything looks fine

@Splaktar
Copy link
Contributor

@jzolnowski please rebase and resolve conflicts.

Let's make any npm and node changes in a separate PR.

@jzolnowski jzolnowski force-pushed the feature/improve-workflow branch from b39ce6b to 8b065f2 Compare March 17, 2023 17:59
@jzolnowski jzolnowski mentioned this pull request Mar 17, 2023
Merged
@jzolnowski
Copy link
Author

Let's make any npm and node changes in a separate PR.

Separate PR created

@jzolnowski
Copy link
Author

Branch is up-to-date with master

@jzolnowski jzolnowski force-pushed the feature/improve-workflow branch from 10258f8 to dca9fcf Compare March 31, 2023 12:33
@jzolnowski
Copy link
Author

Rebased branch with master

@Splaktar
Copy link
Contributor

@jzolnowski please rebase and resolve conflicts.

@jzolnowski jzolnowski force-pushed the feature/improve-workflow branch from dca9fcf to b0f0d54 Compare April 17, 2023 17:49
@jzolnowski
Copy link
Author

@jzolnowski please rebase and resolve conflicts.

Rebased branch with master

gkalpak
gkalpak requested changes Apr 19, 2023
View reviewed changes
@Splaktar
Copy link
Contributor

@jzolnowski please rebase and resolve conflicts.

Splaktar
Splaktar suggested changes Apr 20, 2023
View reviewed changes
jzolnowski and others added 2 commits May 3, 2023 11:16
@jzolnowski
fix: remove duplicated angular-animate package in the switch-to-lts-p…
5893322 
…ackages script, reorder folders in gitignore
fix: update README - AngularJS version that supports Ionic v1 SDK, re…
fc63875 
…move www/lib folder before create a new one
@jzolnowski jzolnowski force-pushed the feature/improve-workflow branch from 4954529 to fc63875 Compare May 3, 2023 09:16
@jzolnowski
Copy link
Author

Rebased branch with master

@Splaktar Splaktar merged commit fb7b358 into master May 3, 2023
@Splaktar Splaktar deleted the feature/improve-workflow branch May 3, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkalpak gkalpak gkalpak approved these changes

+1 more reviewer

@Splaktar Splaktar Splaktar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzolnowski @Splaktar @gkalpak