chore(package.json): update angular.js to v1.9.3 along with other non-angularjs related dependencies #18
Conversation
jzolnowski
force-pushed
the
chore-bump-angularjs
branch
from
aeb1fa4 to
eb81c89
Compare
jzolnowski
force-pushed
the
chore-bump-angularjs
branch
from
eb81c89 to
86b7dad
Compare
jzolnowski
changed the title
angular.js-based librarie means all the rest bumped angularjs-based packages like: |
There was a problem hiding this comment.
The changes lgtm, but I find the commit message confusing/unclear. What does "angular.js-based libraries" refer to?
angular.js-based librarie means all the rest bumped angularjs-based packages like:
"angular-animate": "npm:@xlts.dev/angular-animate@^1.9.2", "angular-aria": "npm:@xlts.dev/angular-aria@^1.9.2", "angular-material": "npm:@xlts.dev/angular-material@^1.2.4", "angular-messages": "npm:@xlts.dev/angular-messages@^1.9.2"
I see. I don't think we need to explicitly mention these libraries in the commit message, since they are part of the AngularJS framework and can be collectively referred to as AngularJS.
But this PR also updates other non-AngularJS related dependencies. We should either mention that in the commit message to move those other updates to a separate commit/PR.
jzolnowski
changed the title
jzolnowski
force-pushed
the
chore-bump-angularjs
branch
from
86b7dad to
1ba8516
Compare
…-angularjs related dependencies After executing `npm install`, `package-lock.json` was also updated to reflect the changes from `package.json`. In the process of updating the lockfile, several versions of the dependencies were upgraded automatically.
jzolnowski
force-pushed
the
chore-bump-angularjs
branch
from
1ba8516 to
832ca7c
Compare
jzolnowski
changed the title
Done |
After executing
npm install,package-lock.jsonwas also updated to reflect the changes frompackage.json.In the process of updating the lockfile, several versions of the dependencies were upgraded automatically.