Skip to content

feat(test): add playwright configuration, add e2e tests, improve esli… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 28, 2023
Merged

feat(test): add playwright configuration, add e2e tests, improve esli… #2

merged 14 commits into from
Mar 28, 2023

Conversation

jzolnowski
Copy link

  • add playwright configuration
  • add e2e tests
  • improve eslint configuration

@jzolnowski jzolnowski requested a review from gkalpak February 8, 2023 20:47
gkalpak
gkalpak requested changes Feb 21, 2023
View reviewed changes
@jzolnowski
Copy link
Author

@gkalpak PR ready for another round of review

gkalpak
gkalpak reviewed Mar 5, 2023
View reviewed changes
gkalpak
gkalpak reviewed Mar 5, 2023
View reviewed changes
gkalpak
gkalpak reviewed Mar 5, 2023
View reviewed changes
@gkalpak gkalpak self-requested a review March 5, 2023 18:21
gkalpak
gkalpak requested changes Mar 5, 2023
View reviewed changes
@jzolnowski
Copy link
Author

@gkalpak PR ready for another round of review

gkalpak
gkalpak requested changes Mar 8, 2023
View reviewed changes
@jzolnowski
Copy link
Author

@gkalpak PR ready for the final review

@gkalpak gkalpak mentioned this pull request Mar 9, 2023
Merged
gkalpak
gkalpak approved these changes Mar 9, 2023
View reviewed changes
Copy link

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Splaktar
Splaktar suggested changes Mar 14, 2023
View reviewed changes
Splaktar
Splaktar reviewed Mar 16, 2023
View reviewed changes
@Splaktar
Copy link

Is it possible to update this repo and the .nvmrc file to NodeJS 18? Right now, it's set to NodeJS 14, but the last commit on master updated the package-lock.json file to v3. If we're going to do that, we should probably update the NodeJS version too.

@jzolnowski
Copy link
Author

Is it possible to update this repo and the .nvmrc file to NodeJS 18? Right now, it's set to NodeJS 14, but the last commit on master updated the package-lock.json file to v3. If we're going to do that, we should probably update the NodeJS version too.

I set the engine-strict flag in .npmrc. I updated the npm and node versions in the package.json engines: npm v9, node>=18. I tested if the package installation, start and testing of the application works correctly. Everything looks fine

Splaktar
Splaktar previously requested changes Mar 16, 2023
View reviewed changes
gkalpak
gkalpak requested changes Mar 18, 2023
View reviewed changes
@gkalpak gkalpak dismissed Splaktar’s stale review March 22, 2023 14:22

Comments have been addressed.

@gkalpak
Copy link

gkalpak commented Mar 22, 2023 •
edited
Loading

@jzolnowski, can you please make sure all commits are signed 🙏

@jzolnowski
Copy link
Author

@jzolnowski, can you please make sure all commits are signed 🙏

All commits signed 🎉
image

@Splaktar Splaktar merged commit 250c7ee into master Mar 28, 2023
@Splaktar Splaktar deleted the feature/e2e-tests branch March 28, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkalpak gkalpak gkalpak approved these changes

+1 more reviewer

@Splaktar Splaktar Splaktar left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzolnowski @Splaktar @gkalpak