Skip to content

Conversation

jzolnowski
Copy link

Migrate dependencies to the latest versions

@jzolnowski jzolnowski requested a review from gkalpak February 8, 2023 20:47
Copy link

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message typo: bum --> bump

@jzolnowski
Copy link
Author

@gkalpak PR ready for another round of review

@jzolnowski jzolnowski changed the title chore: bum dependencies to the latest version chore: bump dependencies to the latest version Feb 24, 2023
@gkalpak gkalpak self-requested a review March 5, 2023 18:43
Copy link

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still the commit message typo (bum --> bump).

Otherwise lgtm 👍

@jzolnowski jzolnowski force-pushed the feature/update-dependencies branch 2 times, most recently from 63d697c to 9c652f1 Compare March 8, 2023 11:42
@jzolnowski
Copy link
Author

Changed commit message

@gkalpak
Copy link

gkalpak commented Mar 16, 2023

@jzolnowski, can you please rebase this on master (avoid merge commits) and make sure the commit is signed? 🙏

@jzolnowski jzolnowski force-pushed the feature/update-dependencies branch from eced21d to e6d8ded Compare March 16, 2023 13:07
@jzolnowski
Copy link
Author

@jzolnowski, can you please rebase this on master (avoid merge commits) and make sure the commit is signed? 🙏

Done

@gkalpak
Copy link

gkalpak commented Mar 16, 2023

The commit does not seem to be recognized as signed by GitHub? Have you set up commit-signing locally?

@jzolnowski
Copy link
Author

The commit does not seem to be recognized as signed by GitHub? Have you set up commit-signing locally?

Fixed that in the current PR:
image

Do you want me to set the signature to the old commits? Or is it good as it is now?

@gkalpak
Copy link

gkalpak commented Mar 18, 2023

All commits should be signed (including old ones) for the PR to be good to go.

@jzolnowski jzolnowski force-pushed the feature/update-dependencies branch 6 times, most recently from cfeab7e to 44504f8 Compare March 20, 2023 11:08
@jzolnowski
Copy link
Author

All commits should be signed (including old ones) for the PR to be good to go.

Commit signed

@gkalpak
Copy link

gkalpak commented Mar 28, 2023

We should also update the PageHome component's template to mention/link to XLTS.dev packages (and update or remove the version numbers).

@Splaktar
Copy link

Please rebase and resolve conflicts.

Jaroslaw Zolnowski added 3 commits March 31, 2023 13:57
@jzolnowski jzolnowski force-pushed the feature/update-dependencies branch from ab94122 to 5eee7a6 Compare March 31, 2023 12:05
@jzolnowski
Copy link
Author

Branch up-to-date with master.
README and PageHome updated.

@jzolnowski jzolnowski force-pushed the feature/update-dependencies branch from 5eee7a6 to 2184b5b Compare April 3, 2023 20:57
@gkalpak gkalpak dismissed Splaktar’s stale review April 4, 2023 12:51

The requested changes have been made.

@gkalpak gkalpak merged commit 681065d into master Apr 4, 2023
@gkalpak gkalpak deleted the feature/update-dependencies branch April 4, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants