fixes Comcast/parodus#194 parse_webpa_url function doesn't correctly return server address #195
Conversation
… server address if it doesn't have port number If the redirect returns a URL which has an URI with "/api/v2/" the parse_webpa_url function must only return in address_buffer the server and not the server/api/v2/ as shown in the test case
|
|
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 88.04% 88.03% -0.01%
==========================================
Files 41 41
Lines 4425 4431 +6
Branches 358 359 +1
==========================================
+ Hits 3896 3901 +5
Misses 198 198
- Partials 331 332 +1
Continue to review full report at Codecov.
|
|
I'm seeing that there is a red line for src/config.c file from code coverage, however it is not from the code I changed. I'm not sure what is your code style for curly brackets on the if statement. |
|
codecov is crazy. |
| @@ -463,6 +463,10 @@ void test_parse_webpa_url () | |||
| addr_buf, 80, port_buf, 8), 0); | |||
| assert_string_equal (addr_buf, "mydns.mycom.net"); | |||
| assert_string_equal (port_buf, "443"); | |||
| assert_int_equal (parse_webpa_url ("https://mydns.mycom.net/api/v2/", | |||
There was a problem hiding this comment.
I didn't even know this was an acceptable url.
But if so, we have to handle it.
There was a problem hiding this comment.
At our company we are seeing it. We are seeing a redirect that has an URI in it, and as we are using default HTTPS port, this bug was easily spotted.
I don't know if you @bill1600 or @schmidtw could merge it, if it also fits Comcast needs.
If it a reshape in any way, I'm all eyes and ears for your comments.
|
Good catch - thanks @nunogmartins ! |
|
Thanks @schmidtw |
If the redirect from Petasos returns a URL which has an URI with "/api/v2/" the
parse_webpa_url function must only return in address_buffer the server
and not the server/api/v2/ as shown in the test case