[result] fix subtest referencing objects

[XonqNopp]

Close #219

[coveralls]

Coverage increased (+0.005%) to 99.603% when pulling 2512b43 on XonqNopp:219_subtest_with_object_breaks_XML_generation into 7723be8 on xmlrunner:master.

[danielfm]

Codecov Report

Merging #220 into master will increase coverage by 5.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   94.48%   99.54%   +5.05%     
==========================================
  Files          15       15              
  Lines        1523     1525       +2     
==========================================
+ Hits         1439     1518      +79     
+ Misses         84        7      -77     

Impacted Files	Coverage Δ
xmlrunner/result.py	98.59% <100.00%> (+0.85%)	⬆️
tests/django_example/app/tests.py	100.00% <0.00%> (ø)
tests/django_example/app2/tests.py	100.00% <0.00%> (ø)
xmlrunner/extra/djangotestrunner.py	96.77% <0.00%> (ø)
tests/django_test.py	100.00% <0.00%> (+74.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a337c...ed4666c. Read the comment docs.

[codecov-io]

Codecov Report

Merging #220 into master will increase coverage by 5.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   94.48%   99.54%   +5.05%     
==========================================
  Files          15       15              
  Lines        1523     1525       +2     
==========================================
+ Hits         1439     1518      +79     
+ Misses         84        7      -77     

Impacted Files	Coverage Δ
xmlrunner/result.py	98.59% <100.00%> (+0.85%)	⬆️
tests/django_example/app/tests.py	100.00% <0.00%> (ø)
tests/django_example/app2/tests.py	100.00% <0.00%> (ø)
xmlrunner/extra/djangotestrunner.py	96.77% <0.00%> (ø)
tests/django_test.py	100.00% <0.00%> (+74.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a337c...ed4666c. Read the comment docs.

[XonqNopp]

Actually it should also fix when there are floats in the subtest

[XonqNopp]

@dnozay did I do something wrong?

[dnozay]

@XonqNopp - it would be good to have a unit test that demonstrates / exercises the incorrect behavior.

[XonqNopp]

I added tests and tried them: before the fix, the build failed https://travis-ci.org/github/xmlrunner/unittest-xml-reporting/builds/676106789

With the fix it is now passing https://travis-ci.org/github/xmlrunner/unittest-xml-reporting/builds/676107976

However, the pytest step failed. And I must admit that I cannot understand what is wrong after reading the log for 15min. Can you please give me a hint as to what I should fix?

[XonqNopp]

@dnozay any help to understand how to fix the test would be appreciated ;-)

[dnozay]

__________________ TestCaseSubclassWithNoSuper.test_something __________________
cls = <class '_pytest.runner.CallInfo'>
func = <function call_runtest_hook.<locals>.<lambda> at 0x7f208078a550>
when = 'call'
reraise = (<class '_pytest.outcomes.Exit'>, <class 'KeyboardInterrupt'>)
    @classmethod
    def from_call(cls, func, when, reraise=None) -> "CallInfo":
        #: context of invocation: one of "setup", "call",
        #: "teardown", "memocollect"
        start = time()
        excinfo = None
        try:
>           result = func()
.tox/pytest/lib/python3.8/site-packages/_pytest/runner.py:244: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.tox/pytest/lib/python3.8/site-packages/_pytest/runner.py:217: in <lambda>
    lambda: ihook(item=item, **kwds), when=when, reraise=reraise
.tox/pytest/lib/python3.8/site-packages/pluggy/hooks.py:286: in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
.tox/pytest/lib/python3.8/site-packages/pluggy/manager.py:93: in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
.tox/pytest/lib/python3.8/site-packages/pluggy/manager.py:84: in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
.tox/pytest/lib/python3.8/site-packages/_pytest/runner.py:143: in pytest_runtest_call
    raise e
.tox/pytest/lib/python3.8/site-packages/_pytest/runner.py:135: in pytest_runtest_call
    item.runtest()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <TestCaseFunction test_something>
    def runtest(self):
        # TODO: move testcase reporter into separate class, this shouldnt be on item
        import unittest
    
>       testMethod = getattr(self._testcase, self._testcase._testMethodName)
E       AttributeError: 'TestCaseSubclassWithNoSuper' object has no attribute '_testMethodName'
.tox/pytest/lib/python3.8/site-packages/_pytest/unittest.py:210: AttributeError

I think this is an issue on pytest for not practicing defensive coding.
https://github.com/pytest-dev/pytest/blob/92767fec5122a14fbf671374c9162e947278339b/src/_pytest/unittest.py#L206-L210

this seems similar to #189

[dnozay]

https://github.com/python/cpython/blob/3.8/Lib/unittest/case.py#L375-L407

     If it is necessary to override the __init__ method, the base class
    __init__ method must always be called. It is important that subclasses
    should not change the signature of their __init__ method, since instances
    of the classes are instantiated automatically by parts of the framework
    in order to be run.

gonna have to remove the broken test TestCaseSubclassWithNoSuper

[dnozay]

@XonqNopp - can you please rebase and try again? I'll merge if CI passes.

[XonqNopp]

@dnozay all tests passed :-)