Skip to content

Conversation

jonathangreen
Copy link
Contributor

This is a small update to #299 that incorporates the excellent feedback @scoder left on the PR after it was merged. It addresses a couple edge cases where an exception could have been raised and not handled in the original PR.

jonathangreen and others added 3 commits March 28, 2024 09:36
Co-authored-by: scoder <stefan_ml@behnel.de>
Co-authored-by: scoder <stefan_ml@behnel.de>
Co-authored-by: scoder <stefan_ml@behnel.de>
@jonathangreen
Copy link
Contributor Author

Thanks @scoder, appreciate you taking the time to review here! I committed those suggested changes.

@jonathangreen
Copy link
Contributor Author

@jimjag I think this one is ready to go and might be good to get merged before a release.

@jimjag jimjag merged commit 749c7fa into xmlsec:master Apr 1, 2024
@jonathangreen jonathangreen deleted the feature/version-check-code-review-updates branch November 14, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants