X11 XReadBitmap API support. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport use case issue for XmoBar github issue #87.
|
Could you propose a patch that does something reasonable with the return value (that indicates success or failure)? Also, the type of the foreign import looks like it should have "Ptr Dimension" in the width_return and height_return slots, which should let you avoid doing a sketchy-looking fromIntegral. |
Signed-off-by: Edward O'Callaghan <victoredwardocallaghan@gmail.com>
|
+dmwit Cheers, |
|
Hello? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
G'day,
This patch adds support for the libX11 XReadBitmapFile API. This resolve a downstream support use case issue for XmoBar github issue #87.
Background found here:
https://github.com/jaor/xmobar/pull/87
May we please merge this here upstream for other possible uses, perhaps in XMonad for example?
Kind Regards,
Edward O'Callaghan.